Authentication upgrade #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakbailey
reviewed
May 2, 2019
Contributor
hakbailey
left a comment
hakbailey
left a comment
There was a problem hiding this comment.
It looks like you're repeating this authentication code block in most of the files in this repo. Since you've found an error in it and have to edit every file anyway, I would strongly suggest moving the authentication process into a function that gets called by each script, rather than continuing to duplicate the code everywhere. It will be much easier to maintain and test.
Contributor
Author
|
After discussion with Helen, I will merge this PR so that the scripts are properly functional as standalone entities and issue it as a release. Afterward, I will begin breaking out repeated code blocks as functions for easier editing and testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After testing some scripts against the new DSpace instance to confirm that I could authenticate with my account, I discovered an error in the authentication code block I was using across all scripts. This PR fixes that code block across the repo. I still want these to be self-contained procedural scripts for easier reuse by others who may be newer to coding. However, I will likely redesign my approach to this work as we start building up more API-based workflows around DSpace down the line.
Includes new or updated dependencies?
NO